Xinha Discussion Forum

Practicality

Xinha Community Member

Registered: 2007-02-15

Posts: 24

Change Addition Process

Hello Xinha developers (and admins, etc),

I have uploaded a proposed addition to the stylist editor.

http://xinha.python-hosting.com/ticket/945

Is this all I need to do to add this change? Is there some kind of code review/formatting that it needs to go through first?

Also, I intend to add some tweaks to the CleanHTML function (it misses things; like the 10 blank lines at the beginning of a document—as well as when you don't have the convert curly quotes to strait checked, it still converts them to strait.... grrrr).

If it would be easier for you that I could just edit these files (and you are sure you want that), please allow me access. I can upload my changes as I make them. We are using this on a live CMS, and as such I will be making extensive changes as users request features.

Also. Thank you very much for your great work. It is greatly appreciated. You have saved me 98% of the work (if not more) and probably months of development time.

ray

Xinha Administrator

From: Germany

Registered: 2005-03-23

Posts: 521

Website

Re: Change Addition Process

Your code looks OK from the first glance, and good coders are always welcome. You would have to mail James (james@gogo.co.nz) if you want to contribute files to the svn

I have also replied to your ticket