Xinha Discussion Forum

mjpg

Xinha Community Member

Registered: 2006-09-28

Posts: 13

How do I get EFM to work with files as well as images?

I have EFM installed and working OK on images.
The Readme says:
"If Insert File Link Mode is enabled, a new icon will be added to the toolbar with advanced file linking capability."
I have linker as a plugin, and that replaces the standard HTMLArea link icon - how do I get EFM to work on files/links?

Thanks

koto

Xinha Pro

Registered: 2006-01-09

Posts: 58

Re: How do I get EFM to work with files as well as images?

Linker is another plugin, and it works as you stated by replacing native 'create link' button. The 'insert file' link looks like this:

It works with default configuration of the EFM plugin

mjpg

Xinha Community Member

Registered: 2006-09-28

Posts: 13

Re: How do I get EFM to work with files as well as images?

Thanks.

Your post led me to the answer - I have a toolbar config and when this is operating, the icon is not shown.

Does EFM use a standard button as a 'hook'? If so, which one. I do need to configure the toolbar and have EFM if possible.

My toolbar config is:

  xinha_editors.bodytext.config.toolbar =
  [
    ["popupeditor"],
    ["separator","formatblock","bold","italic"],
    ["linebreak","separator","justifyleft","justifycenter","justifyright"],
    ["separator","insertorderedlist","insertunorderedlist"],
    ["separator","inserthorizontalrule","createlink","insertimage","inserttable","toggleborders"],
    ["linebreak","separator","undo","redo"], (HTMLArea.is_gecko ? [] : ["cut","copy","paste"]),
    ["separator","htmlmode"]
  ];

koto

Xinha Pro

Registered: 2006-01-09

Posts: 58

Re: How do I get EFM to work with files as well as images?

No, it has its own custom button - its id is 'linkfile'.

See this code snippet from extended-file-manager.js:

        cfg.registerButton({
            id        : "linkfile",
            tooltip   : HTMLArea._lc("Insert File Link",'ExtendedFileManager'),
            image     : _editor_url + 'plugins/ExtendedFileManager/img/ed_linkfile.gif',
            textMode  : false,
            action    : function(editor) {
                    editor._linkFile();
                  }
            });
        cfg.addToolbarElement("linkfile", "createlink", 1);

mjpg

Xinha Community Member

Registered: 2006-09-28

Posts: 13

Re: How do I get EFM to work with files as well as images?

Thanks for your help. I see the problem.

SOLUTION:
Add "linkfile" to custom config like this:

  xinha_editors.bodytext.config.toolbar =
  [
     .......other tools.......
    ["separator","htmlmode","linkfile"]
  ];

REASON (I think)
EFM (in 'extended-file-manager.js') adds the icon to the end of the default toolbar (set in htmlarea.js with this:
    cfg.toolbar.push([ "linkfile" ]);

The custom config REPLACES the default config (including the added "linkfile") and so it does not appear unless added in the custom.

================================

I have another related problem with EFM - although I have set a different file directory in EFM/config.inc.php - it DOES NOT appear. Any ideas?

code is:

if ($insertMode == 'image') $IMConfig['images_dir'] = $_SERVER['DOCUMENT_ROOT'].'/pics';
else if($insertMode == 'link') $IMConfig['images_dir'] = $_SERVER['DOCUMENT_ROOT'].'/downloads';

AND

if ($insertMode == 'image')
    $IMConfig['images_url'] = "/pics";
else if($insertMode == 'link')
    $IMConfig['images_url'] = "/downloads";

Thanks in advance

ray

Xinha Administrator

From: Germany

Registered: 2005-03-23

Posts: 521

Website

Re: How do I get EFM to work with files as well as images?

There has be somewhat of a development In EFM, there is now a separate setting for the files directory which is $IMConfig['files_dir'].
Though it results in  a certain backwards incompatibility, it seemed advisable as it allows complete configurability from config.js which in turn faciliates the updating process.
There are also a bunch of other new options, so have a look at config.inc.php and the included readme file which provides instructions about the new frontend config system.
Sorry for any inconvenience.

As to the button problem: no, you don't have to add buttons from plugins to your custom toolbar. They appear on their own and are added by the plugin to whichever toolbar provided.

mjpg

Xinha Community Member

Registered: 2006-09-28

Posts: 13

Re: How do I get EFM to work with files as well as images?

Thanks. I downloaded the new nightly and this all works fine now.

Can I give some feedback on this great utility (using IE6 on Windows XP Pro)?

* URL is corrected inserted in the <a href as "http://www.domain.com/downloads/filename.ext" BUT shown in the EFM dialog as "/filename.ext". It would give reassurance if it were "/downloads/filename.ext".

* If you upload a file, the JS alert has odd extra characters:
File "$file=filename.ext$" sucessfully uploaded.

* It would be fantastic to be able to MOVE files beween folders using EFM.

Thanks for all the help and advice.

ray

Xinha Administrator

From: Germany

Registered: 2005-03-23

Posts: 521

Website

Re: How do I get EFM to work with files as well as images?

* If you upload a file, the JS alert has odd extra characters:
File "$file=filename.ext$" sucessfully uploaded.

Hmm, this should actually be replaced. Did you also update htmlarea.js?

* It would be fantastic to be able to MOVE files beween folders using EFM.

Interesting Idea, create a ticket

* URL is corrected inserted in the <a href as "http://www.domain.com/downloads/filename.ext" BUT shown in the EFM dialog as "/filename.ext". It would give reassurance if it were "/downloads/filename.ext".

Not such good idea imho, because it it is not in every case desirable that the user knows about the complete path

Last edited by ray (2006-09-29 08:41:09)

mjpg

Xinha Community Member

Registered: 2006-09-28

Posts: 13

Re: How do I get EFM to work with files as well as images?

Updating htmlarea.js DID fix this.

I guess I'll have to point an SVN client at the source and check the Timeline page a bit more.

Sorry about my questions taking your time. I'm not used to there not being a stable release.

By the way, there's no ticket catgegory for EFM.

mjpg

Xinha Community Member

Registered: 2006-09-28

Posts: 13

Re: How do I get EFM to work with files as well as images?

Re - custom toolbar.

... you don't have to add buttons from plugins to your custom toolbar. They appear on their own and are added by the plugin to whichever toolbar provided.

This does not work on my install. With this config, EFM DOES NOT add an icon.

  
xinha_editors.bodytext.config.toolbar =
  [
    ["popupeditor"],
    ["separator","formatblock","bold","italic"],
    ["linebreak","separator","justifyleft","justifycenter","justifyright"],
    ["separator","insertorderedlist","insertunorderedlist"],
    ["separator","inserthorizontalrule","createlink","insertimage","inserttable","toggleborders"],
    ["linebreak","separator","undo","redo"], (HTMLArea.is_gecko ? [] : ["cut","copy","paste"]),
    ["separator","htmlmode"]
  ];

It does if I add ,"linkfile" explicitly.

koto

Xinha Pro

Registered: 2006-01-09

Posts: 58

Re: How do I get EFM to work with files as well as images?

Hmm,

    cfg.toolbar.push([ "linkfile" ]);

This was changed in rev 579 (19.09.2006) - are you sure this toolbar thing does not work with the current version?

mjpg

Xinha Community Member

Registered: 2006-09-28

Posts: 13

Re: How do I get EFM to work with files as well as images?

I'll update everything to the latest version and have another go to check.

Thanks