Fix for form.submit();

noxi · 2006-07-28 09:47:15

hi, havent been here in ages,but just recently had a project that required Xinha again and got bugged with the submit() bug. So heres a fix for it
I couldnt log into Tickets so im posting here, sry o.o

    if (!this._textArea.form.$XINHA_submit){
        this._textArea.form.$XINHA_submit = this._textArea.form.submit;
        this._textArea.form.submit = 
            function(){
                for(var i=0;i < this.elements.length; i++){
                    var element = this.elements[i];
                    if (element.type != 'textarea') continue;

                    for (var a=0; a  < __htmlareas.length;a++){
                        var editor = __htmlareas[a];
                        if (editor._textArea == element){
                            element.value = editor.outwardHtml(editor.getHTML());
                        }
                    }//for - each editor
                }//for - each element
                this.$XINHA_submit();
            }//function
    }//if

gogo · 2006-07-28 22:33:49

http://xinha.python-hosting.com/ticket/823

brice · 2006-07-29 00:32:12

Is this bug responsible for the strange, laggy behavior when a form containing the xinha editor is submitted? I'm experiences a slowdown upon submit, followed by the xinha editor re-painting itself in various areas of the screen, and then finally submitting after 7-8 seconds. This is occuring under FF 1.5/Linux, and IE6/Linux Wine -- on the latest nightly snapshot including the example pages.

If so, where can I apply this patch?

Thanks!

~ Brice

noxi · 2006-07-29 05:49:29

no this simply fixes the the ability to call <form element>.submit() directly and not have to first call onsubmit to be sure the content of the htmlarea is submitted

Last edited by noxi (2006-07-29 05:54:48)

brice · 2006-07-30 22:33:13

noxi,
I see. My eyes are too used to jQuery

Anyway, is the strangeness I described a known issuie?

Thanks,

~ Brice

gogo · 2006-07-30 23:35:46

brice: The repainting is a new one. The slowdown might be if you are editing a large amount of HTML, try using the GetHtml plugin.

MynameisMJ · 2006-07-31 16:21:52

brice - FWIW, I found the lag appears in r532+ while the repainting bug appeared in r533+
(See http://xinha.python-hosting.com/ticket/825)

Last edited by MynameisMJ (2006-07-31 16:30:42)

mokhet · 2006-08-01 02:48:49

Yes, everything explained in ticket 825

brice · 2006-08-01 19:59:47

Great. Thanks for the response guys! I'll remain on standby

~ brice

Xinha Discussion Forum

Announcement

#1 2006-07-28 09:47:15

Fix for form.submit();

#2 2006-07-28 22:33:49

Re: Fix for form.submit();

#3 2006-07-29 00:32:12

Re: Fix for form.submit();

#4 2006-07-29 05:49:29

Re: Fix for form.submit();

#5 2006-07-30 22:33:13

Re: Fix for form.submit();

#6 2006-07-30 23:35:46

Re: Fix for form.submit();

#7 2006-07-31 16:21:52

Re: Fix for form.submit();

#8 2006-08-01 02:48:49

Re: Fix for form.submit();

#9 2006-08-01 19:59:47

Re: Fix for form.submit();

Board footer