New ExtendedFileManager (EFM) :)

koto · 2006-06-19 16:32:51

Hi!

I just want to let you know, that a few days ago I started modifying somewhat old EFM 1.0 beta plugin (that's the latest version I could get) - the original autor website is dead, so I did some reworks myself.

The changelog is as follows:

- changed i18n algorithm to the one currently used by Xinha
- integrated unified backend code from ImageManager plugin and the ability to
pass configuration through PHP session (ImageManager)
- added currently selected image preview (code taken from ImageManager plugin)
- various i18n fixes
- rearranged manager window (now is bigger)
- bugfix: launching manager with already selected image/link retrieves correct
relative URL and goes to image/link directory (code taken from ImageManager)
- added ability to automatically resize image on accepting dialog (ImageManager)
- replaced newFolder.html with simple javascript prompt
- removed non-used code from .js files
- ExtendedFileManager now uses classes from ImageManager direcory
(to avoid code duplication)
- replaced base_dir/base_url settings with images_dir/images_url
- base_url is now used for frontend to backend path (like in ImageManager plugin)
- added 'allowed_image_extensions','allowed_link_extensions',
'max_filesize_kb_image', 'max_filesize_kb_link' config settings
in place of 'allowed_extensions' and 'max_filesize_kb'
- if config setting 'max_foldersize_kb' = 0 , no size information is displayed
in manager
- 'img_library' config setting is now true by default, and GD is used by default
- changed all short PHP tags <? to <?php
- selecting an image after saving it with the editor
- removed DOCTYPE from images.php to toggle quirks mode in IE and get rid of
horizontal scrollbar
- added Polish translation file
- various small fixes, usually taken from ImageManager diffs

So, basically EFM has become ImageManager deluxe, probably covering each and every feature of the latter.

I'll try to send the zip with the new EFM tomorrow (still some tiny things left to do).

I think that, in the future, EFM could replace ImageManager as the latter provides only a subset of EFM's functionality. What do you think?

After testing the current version - I've named it 1.1 - I'll try to incorporate the changes from recent http://fckplugins.saulmade.nl/ FCKEditor version of the EFM plugin. There are some very exciting features there like watermarking etc.

Is there any interest in incorporating EFM into Xinha at all? I remember that everyone was waiting for the 1.0 final version year ago or so, but since then nothing happened.

Cheers,
Krzysztof Kotowicz

koto · 2006-06-19 21:57:21

Ok, I've submitted the code to new ticket, accompanied with the diff file with changes from 1.0 beta. Please test....

Direct link to the archive with the plugin : ExtendedFileManager_1_1.tgz

Cheers,
Krzysztof Kotowicz

Last edited by koto (2006-06-19 21:58:47)

niko · 2006-06-20 06:45:02

nice!!!
i tried it and it really works great!

imho it could replace the ImageManager if it has all features and the insert-file-mode can be switched off.

i also took a look at the ImageEditor-FCKEdit-plugin
i like the way you can edit the image directly in the editor - without having to open a ImageManager.
but that would be a new xinha-plugin i suggest.... (should use same code as EFM-Editor)

keep up the good work!
niko

koto · 2006-06-20 20:12:00

Thanks for your opinion, I'm happy that you liked it

New version is uploaded to the ticket - small changes and improvements

- corrected JS files, added semicolons for future JS compression,
standarized whitespace etc
- HSPACE / VSPACE replaced by margin / padding settings (ImageManager)
- added optional color pickers ('use_color_pickers' config setting) for
background / border colors (ported from ImageManager + a few fixes)
- bugfix: fixed error when URLs did not always have base_url stripped
(now Xinha's baseHref is prepended to relative URLs and base_url stripped
after that)
- bugfix: applied changeset 114 (IE error when linking image)

With new colorpickers I am sure that the plugin covers all the features of ImageManager (I browsed through the SVN history for the plugin). So I'll try to work out how to make the link button optional.

Currently the max_folder_size issues an error, because ImageManager classes have one function from EFM missing. I don't issue any ticket for this , ImageManager classes would probably be upgraded with EFM commit.

Possibly the EFM plugin will be under heavy development by me - it's very useful for the apllications i'm using. Also, I've discovered some minor bugs in ImageManager, so I don't know which way should we go - maintain both packages or just one of them?

Is it possible to get SVN account for Xinha? I used to upload translation files and now the EFM plugin through ticket system, but it just slows things down, if you know what i mean

Cheers,
Krzysztof Kotowicz

niko · 2006-06-21 02:17:12

for an svn-account ask gogo.

and he is the one how should deside what happens to the ImageManager-plugin if the new EFM does everything.
(probably you could write a ImageManager-upgrade-plugin that has the same interface but internaly calls EFM - so we have the code only once to maintain - but users can still use the old ImageManager)

niko

gogo · 2006-06-25 23:55:09

I have sent koto login details for SVN and Trac. As for EFM replacing IM. I think we should keep both. Some people might not require everything that EFM does and only wants and only want IM features (and not to mention, having a plugin disappear when people upgrade would be problematic).

Ecco · 2006-06-26 05:06:06

Hi y'all.

Great to have a Xinha-specific version of the EFM now. Congratulations !

I wonder, is this the request-section?

Would it be possible for us to verify the uploads at some point, after the upload, but still in the EFM ? I'd like to check whether images aren't too big, and whether movies are really movies, etcetera.

I tried the EFM in a directory with more than 600 files. It worked fine, but naturally it takes ages to load. A loading message would be nice, as you get the impression that there's something wrong.

koto · 2006-07-04 10:28:28

Ecco: as for images size - this would be possible - maybe some config values like max_image_width or max_image_height and optional resizing in background. But I don't know how could you verify other file formats (like movies).

Loading message - ok, i'll put it on my list.

There is a new, I think, useful feature commited to the trunk - rename files. Details in Ticket 818.

Please test and comment.

ray · 2006-07-12 18:58:29

Hi koto,
great work, just wanted to thank you!

mairavykus · 2006-07-13 16:12:28

Can you place an example on same page so we can try it, without installing it?
Thanks in advance.

koto · 2006-07-14 09:45:33

With the newest commit the default Xinha demo includes ExtendedFileManager plugin working. Just select EFM and NOT ImageManager in the checkboxes.

THIS LINK WILL WORK WHEN THE NEWEST NIGHTLY WILL BE BUILT. Current build will result in 'invalid base directory' error message.

Here's the link: http://xinha.gogo.co.nz/xinha-nightly/e … ample.html

Ecco · 2006-07-15 05:31:07

I always assign a (sub-) directory to a session-variable. This works with the Image Manager, but not with the Extended File Manager.

It seems that as soon as session-variables are used, the EFM displays the image directory, and returns links to the images as if they were in the file-directory. Like 'http://www.domain.nl/files/IMAGE.jpg'.

Code :

if(empty($insertMode))
$insertMode="image";

if ($insertMode == 'image') {
$IMConfig['view_type'] = "thumbview";
$IMConfig['images_dir'] = $_SERVER["DOCUMENT_ROOT"]."/images/".$_SESSION["img_submap"];
$IMConfig['images_url'] = "http://www.domain.nl/images/".$_SESSION["img_submap"];
}
else if($insertMode == "link") {
$IMConfig['view_type'] = "listview";
$IMConfig['images_dir'] = $_SERVER["DOCUMENT_ROOT"]."/files/".$_SESSION["img_submap"];
$IMConfig['images_url'] = "http://www.domain.nl/files/".$_SESSION["img_submap"];
}

$IMConfig['insert_mode'] = $insertMode;

koto · 2006-07-15 11:37:20

Hi, Ecco

I'll look into this, i just need some more details/explanation:

- does the snippet of code you pasted come from your modified version of config.inc.php file, or is it part of script file that constructs xinha_config.ExtendedFileManager object? In other words, are you using static, or dynamic configuration of the EFM plugin? See the 'Installation' part of readme.txt if in doubt.

If this is the first option, please take into consideration that session_start() in the config.inc.php file is near the bottom, so the session variables could be not available before that call (depends on the session.auto_start PHP setting). Try moving that code to the very bottom of config.inc.php if that is the case.

- does the plugin work as expected if you simply replaced $_SESSION['img_submap'] with any constant directory? If that is the case, we could narrow the testcase to PHP session-related issues.

Cheers,
Krzysztof Kotowicz

koto · 2006-07-15 11:41:39

You could easily debug session variables by putting file_put_contents('session.log', var_export($_SESSION, true)) in the config.inc.php file, or putting var_dump() call. file_put_contents is a PHP5 function but there is also a PHP4 version here

Cheers,
Krzysztof Kotowicz

Last edited by koto (2006-07-15 11:41:56)

Mr. Picklesworth · 2006-10-01 02:03:40

Hm... Is there an easy way to run this plugin outside of Xinha?
I'm building a little web administration tool with immense help from Xinha and this great plugin, but it seems a bit weird having to open the page editor to upload files.

How can I go about changing settings for EFM aside from editing config.inc.php? It seems a bit silly having to go back and change it every time I update.

Last edited by Mr. Picklesworth (2006-10-01 02:55:47)

koto · 2006-10-01 13:42:19

Hi!

EFM is a Xinha plugin, so currently Xinha is required for it to work. The main interface, file management and image editor is not linked to Xinha functions though - integration with xinha is coded in extended-file-manager.js file and config.inc.php (xinha* functions) - so I guess you could try to implement a stand-alone version of this plugin.

Configuring EFM can be done using xinha_config.ExtendedFileManager object as written in the readme file in the plugin directory.

Mr. Picklesworth · 2006-10-03 01:14:07

Thanks, Koto.

I guess it doesn't actually have to be literally outside of Xinha, but to just look like it is; perhaps I could get the EFM file manager to start immediately without the user needing to click a button?
Then hopefully I could use Xinha without an editor window and it would look rather seamless.

Edit:
Never mind me; I'm moving this to a new thread since I'm drifting a bit off topic.

Last edited by Mr. Picklesworth (2006-10-06 13:05:42)

Xinha Discussion Forum

Announcement

#1 2006-06-19 16:32:51

New ExtendedFileManager (EFM) :)

#2 2006-06-19 21:57:21

Re: New ExtendedFileManager (EFM) :)

#3 2006-06-20 06:45:02

Re: New ExtendedFileManager (EFM) :)

#4 2006-06-20 20:12:00

Re: New ExtendedFileManager (EFM) :)

#5 2006-06-21 02:17:12

Re: New ExtendedFileManager (EFM) :)

#6 2006-06-25 23:55:09

Re: New ExtendedFileManager (EFM) :)

#7 2006-06-26 05:06:06

Re: New ExtendedFileManager (EFM) :)

#8 2006-07-04 10:28:28

Re: New ExtendedFileManager (EFM) :)

#9 2006-07-12 18:58:29

Re: New ExtendedFileManager (EFM) :)

#10 2006-07-13 16:12:28

Re: New ExtendedFileManager (EFM) :)

#11 2006-07-14 09:45:33

Re: New ExtendedFileManager (EFM) :)

#12 2006-07-15 05:31:07

Re: New ExtendedFileManager (EFM) :)

#13 2006-07-15 11:37:20

Re: New ExtendedFileManager (EFM) :)

#14 2006-07-15 11:41:39

Re: New ExtendedFileManager (EFM) :)

#15 2006-10-01 02:03:40

Re: New ExtendedFileManager (EFM) :)

#16 2006-10-01 13:42:19

Re: New ExtendedFileManager (EFM) :)

#17 2006-10-03 01:14:07

Re: New ExtendedFileManager (EFM) :)

Board footer