Xinha needs a stable download and demo back

mharrisonline · 2006-06-10 06:34:44

I don't know if anyone other the people posting to this re-opened ticket have noticed this, but the example still locks up IE and never finishes initiating the editor. Xinha has been unusable in IE since revision 496 on April 30. This problem is detailed in reopened ticket #766 at http://xinha.python-hosting.com/ticket/766.

In other words, for the last month and a half anyone coming to this site in IE to learn more about Xinha has seen a Xinha that didn't work, and all the revisions since 4/30 have been made to an editor that can't be used. If you download Xinha and unzip it it seems to work locally, but it won't work from a Web server. This is an issue in IE6 only, Firefox behaves normally.

This revision (04/30/06 00:30:11 496 496 gogo Fix scrolling for long panels. Refer ticket:543 ... ) added several new lines of code to htmlarea.js beginning at line 1911. I've pasted the problem area below and commented the new lines that if commented or removed allow Xinha to initiate again in IE:

this._iframe.style.height = edcellheight + 'px';
// this._framework.rp_cell.style.height = edcellheight + 'px';
// this._framework.lp_cell.style.height = edcellheight + 'px';

// (re)size the left and right panels so they are equal the editor height
// for(var i = 0; i < this._panels.left.panels.length; i++)
// {
// this._panels.left.panels[i].style.height = this._iframe.style.height;
// }

// for(var i = 0; i < this._panels.right.panels.length; i++)
// {
// this._panels.right.panels[i].style.height = this._iframe.style.height;
// }

var edcellwidth = width;

Is there anyone with developer access that could please either rollback this revision, comment the lines shown above, or fix the issue so that Xinha can work in IE again?

Its an immediate crisis because this code is in the download and the example.

The other day I was looking at the discussion board for a CMS and they were choosing between Xinha and FCKEditor. They didn't like how slow FCKEditor was to load, but iritatingly they choose it because they thought it had more developers working on it. I think it will damage Xinha's reputation if people can't demo or download a stable working version. I just don't think that anyone is aware that this is still an open issue after gogo's try to fix it with changeset:513 on May 8 had no effect.

In IE6, on a Web server, Xinha still gets locked into a permanent loop in the final stages of initiating and won't launch, which locks up the browser to where it can only be closed.

I think that this problem shows that it is important to Xinha that a stable download link and example be reinstated on the Xinha site, not just a nightly example that may not be usable. If there was a stable download and link, Xinha could be broken for several months; anyone could still try or get the last working version.

I realize that this creates work for someone, most likely James, but honestly even if it didn't get updated more than once every six months it would be much better than just showing and linking only to the potentially unstable nightly build. At least there would always be something available to someone needing to choose an editor.

I think that I remember that there used to be a stable download and demo on the site, but that was back when most of the development was urgent fixes for legacy bugs from HTMLArea3, so the stable download was always laughably inferior to the nightly download. Everything is different now. At that time, there were serious problems carried over from HTMLArea3 that were causing a lot of issues. There were also tons of patches and improvements that had been provided by users to the HTMLArea forum or sourceforge project that had not been implemented.

Xinha is a fairly mature editor that has grown past its inherited HTMLArea3 issues. Revisions now are often new plugins or translations, new changes are nice but are usually not something that fixes a problem that was corrupting everyone's content or crashing their workstation. Now, unlike before, it makes a lot of urgent sense to provide a stable demo and download.

wymsy · 2006-06-19 12:18:06

I commented those lines out in changeset:519, and reopened ticket 543, which R496 was supposed to fix.

mharrisonline · 2006-06-20 00:42:18

Thanks, you just made Xinha work in IE again after it had been broken for almost 2 months.

gogo · 2006-06-25 23:44:29

The intention has always been to have a stable download of "1.0" when the list of bugs to be fixed for 1.0 was emptied. Like most things however, that list seems to shrink for a bit, and then grow again.

Perhaps if somebody would like to suggest a revision that they think is a candidate for "almost stableness" then I (or anybody else with Wiki access) can can put that online as a 1.0 pre-release ;-)

As for the broken-ness in IE, I'm not sure what IE's problem is, as you can see in the code mharris posted, the commented out stuff shouldn't ever be able to cause IE to infinite loop. Should it? I mean, it's setting a couple of styles on table cells, and doing the same on all the panels (of which there are probably 0 or 1).

Xinha Discussion Forum

Announcement

#1 2006-06-10 06:34:44

Xinha needs a stable download and demo back

#2 2006-06-19 12:18:06

Re: Xinha needs a stable download and demo back

#3 2006-06-20 00:42:18

Re: Xinha needs a stable download and demo back

#4 2006-06-25 23:44:29

Re: Xinha needs a stable download and demo back

Board footer