Xinha Discussion Forum

niko

Xinha Authority

From: Salzburg/Austria

Registered: 2005-02-14

Posts: 338

replace HTMLArea.loadScript with HTMLArea._loadback

please some comments for my patch:
http://xinha.python-hosting.com/ticket/139

and if we could remove the old built-in-fullscreen-page.

---

Niko

mokhet

Xinha Authority

From: Paris, France

Registered: 2005-04-03

Posts: 105

Website

Re: replace HTMLArea.loadScript with HTMLArea._loadback

please some comments for my patch:
http://xinha.python-hosting.com/ticket/139

well, as always i wonder how the hell you all can do such amazing things with javascript. As far i can understand, there's no need for HTMLArea.init() anymore and when generating first editor you test if scripts are loaded and if they are not,well load them. For me the code is clear and it does the job. I'm not a js expert but i think it's better to have a unified way to load scripts than two functions. And i am sure you know what you doing, so for me if ever it worst anything, i think the patch should be applied.

and if we could remove the old built-in-fullscreen-page.

Cant the fullscreen.html that's loading scripts be updated with HTMLArea._loadback() ?
If no or not in an easy way, well, why again keep two ways of doing the job ? The built-in fullscreen has never been efficient for me and as far i know, none of ppl around me playing with editor have ever used it. But since xinha and the fullscreen plugin, i use it and ppl around me are using it too.

Having a built-in system and a plug-in should be imo turned into plug-in only. The plug-in is better, at least looks better from my side of view, and it is easier to use. Also the plug-in doesnt need another download of scripts when it is called. It is far better i think.

well, my 2 cents